Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Issue #325

Open
yunusyerli1 opened this issue Aug 22, 2023 · 1 comment
Open

Validation Issue #325

yunusyerli1 opened this issue Aug 22, 2023 · 1 comment
Labels
Area: Cases Issues & PRs related to all things regarding the Cases Module Area: Frontend Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Status:Requires Updates Issues & PRs which requires input or update from the author Type: Bug Something isn't working

Comments

@yunusyerli1
Copy link
Contributor

Issue

When creating a Case, Missed Collection's Outcome field required validation appears even if there is a value after "Save and Continue".

Expected Behavior

After filling a value, and click "Save and Continue", validation needs to validated related field.

Actual Behavior

After clicking "Save and Continue", validation doesnt validate the related field.

Possible Fix

Below lines are not in order.
data.field.definition.required = required;
data.field.formControl.setValidators(validators);
data.field.formControl.updateValueAndValidity({onlySelf: true, emitEvent: true});
record.formGroup.updateValueAndValidity({onlySelf: true, emitEvent: true});

Steps to Reproduce

  1. Choose Service as Missed Collection in Case Module.
  2. Select Yes in Further Action Required field.
  3. Fill Outcome field.
  4. Click Save and Continue button.
  5. Check Outcome field again.

Context

Even if you fill a value in Outcome field and click Save and Continue, related field still needs required to fill validation.

Your Environment

  • SuiteCRM Version used: 8.3.0
  • Browser name and version (e.g. Chrome Version 51.0.2704.63 (64-bit)): Chrome Version 115.0.5790.171 (64-bit)
  • Environment name and version (e.g. MySQL, PHP 7): Wamp Server, PHP 7.4.33, MariaDB 10.4.12
  • Operating System and version (e.g Ubuntu 16.04): Windows 11
yunusyerli1 added a commit to yunusyerli1/SuiteCRM-Core that referenced this issue Aug 22, 2023
@johnM2401 johnM2401 added Type: Bug Something isn't working Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status:Requires Updates Issues & PRs which requires input or update from the author Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Area: Cases Issues & PRs related to all things regarding the Cases Module Area: Frontend labels Aug 31, 2023
@johnM2401
Copy link

Hey Yunus!

It looks like the Steps to Replicate here are for a specific customized environment.

If possible, when you get a chance, could you add Steps to Replicate for a generic Vanilla suitecrm environment?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cases Issues & PRs related to all things regarding the Cases Module Area: Frontend Priority:Important Issues & PRs that are important; broken functions; errors; there are workarounds Status: Fix Proposed A issue that has a PR related to it that provides a possible resolution Status:Requires Updates Issues & PRs which requires input or update from the author Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants