Remove skip form install app tests #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5aef03d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NyanKiyoshi
changed the title
NyanKiyoshi
approved these changes
Aug 29, 2024
michalina-graczyk
approved these changes
Aug 30, 2024
Cloud11PL
approved these changes
Sep 3, 2024
Cloud11PL
pushed a commit
that referenced
this pull request
Sep 4, 2024
* remove skip form instal app tests * add project to playwright config * update e2e commands and add changes to workflow * add apps test for run tests on crone workflow * testing workflow * typo * add empty line * add test workflow * restore grep for command * add on push option to test workflow * remove test workflow * remove additional empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr removes skip from test of installing the app in the dashboard and updates the workflow to run those tests only on releases (automatic and manual test trigger) or on crone
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Run all tests before the change, installing app test is skipped:
Run all tests after the change
Test run on PR before the change installing app test is skipped
Test on PR after the change, tests from apps spec are not triggered on PRs
Have you written tests?
[Optional] Description