Deprecate log method and add log_kv method
#8
Conversation
opentracing-ruby deprecated `log` and added `log_kv`. This PR add deprecated annotation and `log_kv`.
| # @param timestamp [Time] time of the log | ||
| # @param fields [Hash] Additional information to log | ||
| def log_kv(timestamp: Time.now, **fields) | ||
| @logs.push({ |
There was a problem hiding this comment.
https://github.com/openzipkin/zipkin-go-opentracing/blob/4c9fbcbd6d73a644fd17214fe475296780c68fb5/zipkin-recorder.go#L179-L185 This is what I found for go implementation but I'm not entirely sure what all of this does. Do you have any other examples?
There was a problem hiding this comment.
@indrekj Thank you your comment.
I'm trying to use this library for our service tracing with event logging, however it doesn't implement .
I found an implementation in zipkin-go-opentracing too.
It seems to send logs that include timestamp and fields converted to strings in Annotations.
I could not find any other implementation, but since it is the official implementation of openzipkin I tried a similar implementation.
|
First commit merged with slight modifications ca0e76d . Thanks. I currently will not merge the second commit as it doesn't define how it will actually be used and seems partial. |
opentracing-ruby deprecated
logand addedlog_kv.This PR add deprecated annotation and
log_kv.