Use Faraday to allow setting SSL configurations #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also loosens the expectation on opentracing
|
We have https://github.com/salemove/jaeger-client-ruby for jaeger integration.
Please don't, 1.0 will likely have breaking changes and we don't want to let it auto-upgrade to it. |
|
@hassox Closing this PR due to lack of activity. Please re-open when listed issues are addressed. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also loosens the expectation on opentracing
When trying to get this library to use a jaeger instance behind peer verified ssl I was unable to hook in. By using Faraday I can write some middleware that takes care of this for me.