Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs doesn't implement #10

Closed
Mahito opened this issue Apr 12, 2018 · 2 comments
Closed

Logs doesn't implement #10

Mahito opened this issue Apr 12, 2018 · 2 comments

Comments

@Mahito
Copy link
Contributor

Mahito commented Apr 12, 2018

I tried to use this library for our service tracing with event logging, however it has not been implemented yet.

I found an implementation in zipkin-go-opentracing.
It seems to send logs that include timestamp and fields converted to strings in Annotations.
I could not find any other implementation, but since it is the official implementation of openzipkin.

I tried a similar implementation.

Sample code and results image using this function are as follows.

require './lib/zipkin/tracer'

OpenTracing.global_tracer = Zipkin::Tracer.build(url: 'http://localhost:9411', service_name: 'echo')

span = OpenTracing.start_span('span name')
span.log_kv({'event': 'test'})
span.log_kv({'key1': 'val1', 'key2': 'val2'})
span.finish
OpenTracing.global_tracer.stop```

implemented log image

@indrekj
Copy link
Member

indrekj commented Apr 12, 2018

@indrekj
Copy link
Member

indrekj commented Apr 12, 2018

Please see #11 and let me know if that looks okay.

@indrekj indrekj closed this as completed Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants