Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for additional otp parameters #25

Merged

Conversation

imahmood
Copy link
Collaborator

@imahmood imahmood commented Sep 8, 2024

Add support for additional OTP parameters in OtpPrepared event.

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.55%. Comparing base (7cc098d) to head (f4d63a9).

Files with missing lines Patch % Lines
src/OtpManager.php 80.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #25      +/-   ##
============================================
+ Coverage     96.45%   96.55%   +0.09%     
  Complexity       35       35              
============================================
  Files             8        8              
  Lines           141      145       +4     
============================================
+ Hits            136      140       +4     
  Misses            5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@salehhashemi1992 salehhashemi1992 merged commit 9b08e34 into salehhashemi1992:main Sep 8, 2024
15 of 17 checks passed
@imahmood imahmood deleted the feature/add-otp-params branch September 8, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants