[ORG] RU-AXAV: KAFKA-13149; Fix NPE when handling malformed record data in produce r… #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equests (#11080) Raise `InvalidRecordException` from `DefaultRecordBatch.readFrom` instead of returning null if there are not enough bytes remaining to read the record. This ensures that the broker can raise a useful exception for malformed record batches. Reviewers: Ismael Juma <[email protected]>, Jason Gustafson <[email protected]>
This patch fixes several problems with the `ElectLeaders` API in KRaft: - `KafkaApis` did not properly forward this request type to the controller. - `ControllerApis` did not handle the request type. - `ElectLeadersRequest.getErrorResponse` may raise NPE when `TopicPartitions` is null. - Controller should not do preferred election if `ElectLeaders` specifies `UNCLEAN` election. - Controller should not do unclean election if `ElectLeaders` specifies `PREFERRED` election. - Controller should use proper error codes to handle cases when desired leader is unavailable or when no election is needed because a desired leader is already elected. - When election for all partitions is requested (indicated with null `TopicPartitions` field), the response should not return partitions for which no election was necessary. In addition to extending the unit test coverage in `ReplicationControlManagerTest`, I have also converted `LeaderElectionCommandTest` to use KRaft. Reviewers: dengziming <[email protected]>, José Armando García Sancio <[email protected]>, David Arthur <[email protected]>
sakibguy
commented
Sep 18, 2021
| @@ -84,7 +84,7 @@ | |||
| EXPIRE_DELEGATION_TOKEN(ApiMessageType.EXPIRE_DELEGATION_TOKEN, false, true), | |||
| DESCRIBE_DELEGATION_TOKEN(ApiMessageType.DESCRIBE_DELEGATION_TOKEN), | |||
| DELETE_GROUPS(ApiMessageType.DELETE_GROUPS), | |||
| ELECT_LEADERS(ApiMessageType.ELECT_LEADERS), | |||
| ELECT_LEADERS(ApiMessageType.ELECT_LEADERS, false, true), | |||
|
|
||
| electionResults.add(electionResult); | ||
| electionResults.add(electionResult); | ||
| } |
| @@ -208,7 +208,7 @@ class BrokerLifecycleManager(val config: KafkaConfig, | |||
| _state = BrokerState.PENDING_CONTROLLED_SHUTDOWN | |||
| // Send the next heartbeat immediately in order to let the controller | |||
| // begin processing the controlled shutdown as soon as possible. | |||
| scheduleNextCommunication(0) | |||
| scheduleNextCommunicationImmediately() | |||
| if (isTraceEnabled) { | ||
| trace(s"Sending broker registration ${data}") | ||
| if (isDebugEnabled) { | ||
| debug(s"Sending broker registration ${data}") |
| @@ -406,7 +406,7 @@ class BrokerLifecycleManager(val config: KafkaConfig, | |||
| scheduleNextCommunicationAfterSuccess() | |||
| } | |||
| } else { | |||
| info(s"The controlled has asked us to exit controlled shutdown.") | |||
| info(s"The controller has asked us to exit controlled shutdown.") | |||
| val createTopicResult = admin.createTopics(newTopics) | ||
| createTopicResult.all().get() | ||
| } | ||
|
|
| )) | ||
| assertTrue(e.getCause.isInstanceOf[TimeoutException]) | ||
| } | ||
| } |
| s"but found ${response.getClass}") | ||
| } | ||
| } | ||
|
|
||
| @AfterEach |
| val requestBuilder = new ElectLeadersRequest.Builder(ElectionType.PREFERRED, null, 30000) | ||
| testKraftForwarding(ApiKeys.ELECT_LEADERS, requestBuilder) | ||
| } | ||
|
|
| requestBuilder | ||
| ) | ||
| } | ||
|
|
sakibguy
changed the title
sakibguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…equests (apache#11080)
Raise
InvalidRecordExceptionfromDefaultRecordBatch.readFrominstead of returning null if there are not enough bytes remaining to read the record. This ensures that the broker can raise a useful exception for malformed record batches.Reviewers: Ismael Juma [email protected], Jason Gustafson [email protected]
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)