Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix long press crash. #10

Closed
wants to merge 1 commit into from

Conversation

crazyhitty
Copy link

Don't execute longClickListener if clickableSpanUnderTouch is null. This would prevent the crash when no ClickableSpan is found under the touched location.

Fixes #9

Don't execute longClickListener if clickableSpanUnderTouch is null. This would prevent the crash when no ClickableSpan is found under the touched location.
@luongvo
Copy link

luongvo commented Oct 16, 2017

@Saketme It should be merged soon 👍

@saket
Copy link
Owner

saket commented Feb 18, 2018

This change avoids the listener from getting called, but doesn't solve the actual cause of the issue -- the long-press timer listener shouldn't get scheduled in the first place if a long-press isn't made on a clickable span. I will make the necessary changes. Thanks for the idea, @crazyhitty.

@saket saket closed this Feb 18, 2018
@crazyhitty
Copy link
Author

Awesome 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants