-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support all ClickableSpans, not just URLSpan. #1
Comments
Whoa, it's JakeWharton! Alright, calm down. Stop smiling. Act normal. The reason I chose not to use @madhu314 has proposed a solution in #2 that basically falls back to scraping the span's text if |
Actually I'm not a big fan of your callback which passes in the URL. Both |
Interesting. I extracted this library from another personal project where I wanted to listen to URL clicks in TextViews across the app and this looked like the easiest way. The only other option I could come up with was replacing all spans inserted by Would you have solved this problem in any other way? |
I've never used |
Alright, merging #2 then. Thanks for contributing, @JakeWharton. |
Move from URL span handling to clickable span, addresses issue #1
As far as I can tell there's no reason to only support
URLSpan
whenClickableSpan
s are commonly used for non-URL linking inside text.The text was updated successfully, but these errors were encountered: