Improve service init script and logs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I'll try to review this sometime this week. |
|
Do you need any clarification ? |
- Fixed init service script to allow proper 'start' and 'stop' actions consistently. I kept struggling that service start only worked after killing the distro because sometimes it didn't start/stop properly leaving processes running and without pid file - Added service 'status' action - Added additional service debug by setting environment variable DEBUG, ie: wsl.exe -d wsl-vpnkit DEBUG=1 service wsl-vpnkit stop - Changed order in startup welcome screen having stop followed by start, this makes it easier for users to just copy/paste from welcome screen to have service running - Added log check command to see only the latest service execution logs
- Added to README how to do start with status firt and how to enable DEBUG - Run tests twice with and without DEBUG enabled
|
Sorry for the wait. |
|
Thanks, please make a new release when possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept struggling that service start only worked after killing the distro because
sometimes it didn't stop properly leaving processes running and without pid file
wsl.exe -d wsl-vpnkit DEBUG=1 service wsl-vpnkit stop
this makes it easier for users to just copy/paste from welcome screen to have
service running