[#16] Allow dynamic setting of label length (^LL) #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `LazyCommand` to support delayed evaluation of a command until `build` is called. Also add `labelLength` overload function that accepts a lambda.
jbduncan
reviewed
Sep 3, 2024
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| package com.sainsburys.k2zpl.builder | |||
|
|
|||
| import LazyCommand | |||
There was a problem hiding this comment.
I'm struck how here we're able to import it as import LazyCommand, but with other types we need to use import com.sainsburys.kzpl....
And indeed, I see the package declaration is missing in LazyCommand.kt! 🙈
There was a problem hiding this comment.
Thank you, i was hasty in the merge I should have waited! I'll fix that right quick 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
LazyCommandto support delayed evaluation of a command untilbuildis called.Also add
labelLengthoverload function that accepts a lambda.