The isset check needs to be !empty

[yavorm]

The isset check fails when $json['error'] is set to false, which is sometimes the case.

[coveralls]

Coverage remained the same at 14.878% when pulling d8e5f06 on yavorm:patch-1 into e568bcc on sailthru:master.

[coveralls]

Coverage remained the same at 14.878% when pulling d320f92 on yavorm:patch-1 into e568bcc on sailthru:master.

[coveralls]

Coverage remained the same at 14.878% when pulling d320f92 on yavorm:patch-1 into e568bcc on sailthru:master.

[yavorm]

Looks like the hhvm test failed on master too.

[silverman63]

Hey @yavorm, thanks for the PR.

I've been notified that there's an issue with the Travis image for HHVM, and need to update the image.

What cases have you seen the API return an empty error string?

[yavorm]

@silverman63
getJobStatus is returning false in that key, not a string. Sorry, we fixed this in our fork a while back and I had forgotten what the specific response was. I'm submitting this PR now so we can potentially get rid of our fork and start using this repo.

[yavorm]

Updated the PR description too.

[yavorm]

@silverman63 Please let me know once you have time to evaluate/merge this PR. Thank you!

[silverman63]

Hi @yavorm, will let you know. Thanks for your patience.

[yavorm]

@silverman63 Can we try to re-run the tests and merge this fix?

[silverman63]

@yavorm will take care this week. Will address #73, let yours retest, and merge. I'm not sure I can guarantee an official release just yet, but it will be in master.

[silverman63]

@yavorm if you pull the latest master change, the test should pass for HHVM.

[coveralls]

Coverage remained the same at 14.85% when pulling e7e436d on yavorm:patch-1 into 9ce1843 on sailthru:master.

[yavorm]

Thank you @silverman63, passed!