Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAASMLOPS-833 add configurable job timeout #7

Merged
merged 2 commits into from
Sep 29, 2023
Merged

SAASMLOPS-833 add configurable job timeout #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f09f003
SAASMLOPS-833 add configurable job timeout
james-crabtree-sp Sep 28, 2023
55727c3
SAASMLOPS-833 fix whitespace
james-crabtree-sp Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdk/python/feast/infra/materialization/contrib/bytewax/bytewax_materialization_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ class BytewaxMaterializationEngineConfig(FeastConfigBaseModel):
retry_limit: int = 2
""" (optional) Maximum number of times to retry a materialization worker pod"""

active_deadline_seconds: int = 86400
""" (optional) Maximum amount of time a materialization job is allowed to run"""

class BytewaxMaterializationEngine(BatchMaterializationEngine):
def __init__(
Expand Down Expand Up @@ -326,6 +328,7 @@ def _create_job_definition(self, job_id, namespace, pods, env):
"backoffLimit": self.batch_engine_config.retry_limit,
"completions": pods,
"parallelism": min(pods, self.batch_engine_config.max_parallelism),
"activeDeadlineSeconds": self.batch_engine_config.active_deadline_seconds,
"completionMode": "Indexed",
"template": {
"metadata": {
Expand Down