Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.64: Revert statx patch for sb2 compatibility #19

Closed
wants to merge 2 commits into from

Conversation

rubdos
Copy link
Contributor

@rubdos rubdos commented Oct 23, 2023

I noticed you were trying out 1.64. Instead of implementing statx in sb2, reverting the statx compatibility patches was actually rather easy, and might provide a workaround.

I tried building this against LLVM 16, but apparently the highest supported LLVM is 14 for 1.64, so I'll retry against that and report back.

Part of The Rust Plan

@rubdos
Copy link
Contributor Author

rubdos commented Oct 23, 2023

I seem to be getting a lot further with LLVM 14, although now I'm getting complaints about not finding crti.o. As far as I understand, that has to do with cross-aarch64-glibc and cross-armv7hl-glibc (and family) not being available (and me commenting them out to try and build). Is there a way to get a hold of these packages? It's weird, since the i486 version is actually available.

@rubdos
Copy link
Contributor Author

rubdos commented Oct 24, 2023

Very close to working :-)

Checking for unpackaged file(s): /usr/lib/rpm/check-files /home/rubdos/rpmbuild/BUILDROOT/rust-1.64.0+git1-1.i386
error: Installed (but unpackaged) file(s) found:
   /usr/libexec/rust-analyzer-proc-macro-srv

EDIT: I removed the executable from the package, since it doesn't seem necessary to have it around for compiling packages. If you'd rather see it packaged, I'd happily add it to %files instead. I have a packaged i486 Rust now.

@rubdos
Copy link
Contributor Author

rubdos commented Oct 24, 2023

Something I just noticed: would it be worth squashing this new patch into 0002-Disable-statx-for-all-builds.-JB-50106.patch, since that targets basically the same issue?

@rubdos rubdos closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant