[qtnetwork] Replace SSL verification error locks #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit should solve QTBUG-76157 by removing the mutex-based error list and instead attaching the error list to either the X509_STORE or SSL struct as ex_data. This bug has been fixed in upstream Qt since 5.12, so this commit may be ignored when upgrading to that Qt version or higher.
|
I didn't give my test app the required internet permission, so all the SSL tests would fail. Now it has the internet permission and it turns out it works just fine. |
|
For clarity, because I may have been a bit chaotic with my communication in the past, the current pull request is ready for review and there are no issues that I'm aware off. |
HenkKalkwater
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should solve QTBUG-76157 by removing the mutex-based error list and instead attaching the error list to either the X509_STORE or SSL struct as
ex_data.I couldn't get the Qt unit tests working, but I have tested this on my device with a small application that I wrote for connecting with servers with known bad SSL certificates and it seems to work as before.
Additionally, my own app Sailfin, does no longer freeze when connecting over HTTPS, so it does solve the problem for me.
I only have tested this on Sailfish 4.4.0.68. I assumed keeping support for older OpenSSL versions than 1.1.0 wasn't necessary, therefore building with older versions than 1.1.0 may fail. Please let me know if that would be an issue.
Related forum topic: https://forum.sailfishos.org/t/possibility-of-backporting-qt-bug-fixes/11424