-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create packaging for libnfnetlink version 1.0.2. #1
base: master
Are you sure you want to change the base?
Conversation
d776776
to
50e491e
Compare
The .spec file almost directly from Fedora. Point to latest tagged release 1.0.2. Update README.md.
50e491e
to
e7af574
Compare
%build | ||
%autogen | ||
%configure --disable-static | ||
%make_build %{?_smp_mflags} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed, the macro %{?_smp_mflags}
is already used in %make_build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite directly from Fedora without any modifications yet. If this, and the libnetfilter_conntrack works for the purpose I intended, I'll modify this and all other things you pointed out, thanks for that.
%install | ||
rm -rf $RPM_BUILD_ROOT | ||
make install DESTDIR=$RPM_BUILD_ROOT | ||
find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be needed either.
%make_build %{?_smp_mflags} | ||
|
||
%install | ||
rm -rf $RPM_BUILD_ROOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant, please remove.
|
||
%install | ||
rm -rf $RPM_BUILD_ROOT | ||
make install DESTDIR=$RPM_BUILD_ROOT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use %make_install please.
Create packaging and use latest released version 1.0.2.