Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An extra dot in the notification bar, when activating a patch #466

Open
tuplasuhveli opened this issue Nov 23, 2024 · 1 comment · May be fixed by #467
Open

An extra dot in the notification bar, when activating a patch #466

tuplasuhveli opened this issue Nov 23, 2024 · 1 comment · May be fixed by #467
Assignees
Labels
bug something that needs fixing

Comments

@tuplasuhveli
Copy link

SailfishOS VERSION (Settings → About product → Build): 4.6.0.15

HARDWARE (Settings → About product → Manufacturer & Product name): Sony Xperia 10 V

PATCHMANAGER VERSION (Settings → Patchmanager → <Top pulley> → About): 3.2.11

BUG DESCRIPTION

The notification bar contains an extra dot, at least in English (UK) UI, when user activates a patch. See the screenshot below in the additional information section.

STEPS TO REPRODUCE

  1. Have a patch installed
  2. Activate the patch
  3. Take a look at the notification bar

ADDITIONAL INFORMATION

patchmanager_notification

@tuplasuhveli tuplasuhveli added the bug something that needs fixing label Nov 23, 2024
@Olf0 Olf0 self-assigned this Nov 24, 2024
Olf0 added a commit that referenced this issue Nov 24, 2024
… text, because the (original) initial message `Patch %1 activated.` (line 278) is either extended by `, ` (line 280) and `some service(s) should be restarted.` (line 281), or concluded with `.` (line 284).
Fixes #466
@Olf0
Copy link
Contributor

Olf0 commented Nov 24, 2024

Thank you for your bug report.
Yes, this looks like a simple oversight, because the logic is already there. Also, when ", some service(s) should be restarted." is not appended, this notification should ultimately become wrongly concluded with an additional full stop, resulting in "Patch %1 activated..".

Not only the en-GB translation is affected, all translations are, because the string "Patch %1 activated." (including the superfluous full stop) is the phrase displayed at Transifex for translation: Consequently all maintained translations include this superfluous full stop, except for one (either accidentally or by understanding, but then not opening an issue).

I addressed this in PR #467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something that needs fixing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants