Four new comics

[ExTechOp]

This adds four new comics, which I've now tested for a few days:

• backtobc (John Hart's B.C. back from when it was superb)
• kevinandkell (Bill Holbrook's Kevin & Kell, the world's longest-running daily webcomic)
• sequentialart (Phillip "Jolly Jack" M. Jackson's Sequential Art)
• viiviandwagner (Jussi "Juba" Tuomola's Viivi and Wagner, English-language version of viivijawagner)

Closes tardypad issue #121 (request for Sequential Art).

[Olf0]

Thank you very much, @ExTechOp!

In order to keep things organised (IOW, to prevent me from becoming confused):

• Please let us finish PR Add four (down from 5) new strips, fix one old one #108, first!
  There are a few open questions which arose from my review last week. Please answer them briefly, I don't mind if you or me then implement corresponding changes.
• In general (but do not care about this here: It will be fine in the git-history, if I merge PR #108 first, but we must not add any additional commits for PR #108 to this branch):
  If you want to contribute something unrelated to a former PR and its branch (here: adding 4 new strips), please start anew from the default branch (i.e. devel for Daily Comics): You can either synchronise the devel branch in your cloned repository with "upstream" (i.e. the one of sailfishos-applications) and start from that (this method is the most easy one when working with a local clone of a remote repository), or start in GitHub's web-frontend editing something in the default branch of "upstream".
  This way the commits from PR #108 would not have shown up in PR Four new comics #111; but as stated before, all is fine when I merge PR #108 first.

[ExTechOp]

In order to keep things organised (IOW, to prevent me from becoming confused):

• Please let us finish PR Add 5 new strips, fix one old one #108, first!
  There are a few open questions which arose from my review last week. Please answer them briefly, I don't mind if you or me then implement corresponding changes.

I'm sorry, I really don't quite see what questions still are open there, can you rephrase them?

• In general (but do not care about this here: It will be fine in the git-history, if I merge PR #108 first, but we must not add any additional commits for PR #108 to this branch):
  If you want to contribute something unrelated to a former PR and its branch (here: adding 4 new strips), please start anew from the default branch (i.e. devel for Daily Comics): You can either synchronise the devel branch in your cloned repository with "upstream" (i.e. the one of sailfishos-applications) and start from that (this method is the most easy one when working with a local clone of a remote repository), or start in GitHub's web-frontend editing something in the default branch of "upstream".
  This way the commits from PR #108 would not have shown up in PR Four new comics #111; but as stated before, all is fine when I merge PR #108 first.

Sorry, I will keep that in mind in the future. As I said, I haven't had time to really get into the nitty-gritty bits of how github is supposed to be used.

[Olf0]

Last thing first:

I haven't had time to really get into the nitty-gritty bits of how github is supposed to be used.

Never mind about "really get[ting] into the nitty-gritty bits of […] [git and] github['s web-frontend]", learning by doing is sufficient as far as I can tell after a few years.

Hence I am trying to provide some advice which helps you to get along well quicker (i.e. advice which I would have been glad to receive half a decade ago).

In this context:

I'm sorry, I really don't quite see what questions still are open there

I utilised GitHub's "review" functionality for these questions, which is a little awkward to use, but makes discussing multiple locations of a PR in parallel much easier:
It allows to quote a small section from a PR (at least four lines are displayed, usually only the last line of these is relevant, as it is the case with my four review-comments for PR #108) and have a conversation about exactly this part of a PR (i.e. a discussion sub-thread).

I wrote four review-comments, but only the first two contain real questions, the first one a single question, the second one two (feel free to also add comments to the third an fourth review-comment, if you like):

1. 108#review-thread-1174043601
2. 108#review-thread-1174044019

The links I provided here are just jump-marks (i.e. jumping to HTML id tags) within the Conversation "tab" of PR #108, so that the page is displayed scrolled down exactly as much to let the location where the id tag is embedded in the HTML source code being displayed at the top of the browser window. Side note: Sometimes browsers scroll a little to far down and one has to scroll very little up to see the start of the section (i.e. where the id tag is embedded) which was intended to jump to.

If you follow each of these links (e.g. open them in new browser-tabs), on top of the browser window you should see four lines quoted from the PR, below that my comment WRT the last of these four lines and then an empty text field (at first just a single line field, which expands as you type), where you should input your reply.

If you still face issues using that as GitHub designed it, then you might take a look at this description with screenshots (another software, PR and contributor, the same usability issue).

[Olf0]

Something seems to go wrong with GitHub's "review" functionality lately. I order to proceed, I just made screenshots of my four review comments and uploaded them on the "Conversation"-page of PR #108.

P.S.: Maybe some JavaScript filter (I use NoScript and uBlockOrigin) is in the way? JavaScript must be allowed for github.com (plus fetch and ping) and githubassets.com (plus fetch).

[Olf0]

All right, now that I merged PR #108 into devel and then updated this PR #111 with the recent commits (from PR #108) from devel, this branch four_new_comics only differs from devel by the … four new comics.
Hence I can now review these changes without having the changes of PR #108 intermingled. Will do, when I have some time.

[Olf0]

My review:

1. Please HTTPS-ify all links which do not explicitly require HTTP as transport protocol (which you did so nicely in the past):
   • backtobc
   • viiviandwagner
2. kevinandkell: Why is the returned string statically prefixed with the stripSource? I.e. is simply returning the match[1] not sufficient here? IIRC a path without a prefixed http[s] is automatically appended to the stripSource URL, at least that is how I documented it. If this does not work, I would like to know in order to rectify the documentation.
   _{Note that "relative link" may mean that it also must not start with an slash (/), you may try either way or read the source code: I will gladly document the result of your research, i.e. be more specific in the documentation about the supported link formats.}

---

BTW, I altered all color values, because …

• some were all white (ffffff), one was almost all white (f0f0f0 was not distinguishable from all white with my screen and eye).
• some where the same.

[Olf0]

New cover for "Back to B.C."
Original JPEG (link):	Cropped PNG:	Cropped and shifted-downwards PNG:
With frame in color 5eb2a5: First try with frame in color 62b4a8	JPEG scaled to 300x300 px² (color 5eb2a5): First try with frame in color 62b4a8 First try without frame	JPEG scaled to 1000x1000 px² (color 5eb2a5):

TL;DR

Please use link_wo_title_large_cbc_bc_201706281341_cropped-framed-scaled_v2.jpg as cover.jpg, link_wo_title_large_cbc_bc_201706281341_cropped-framed-scaled_v2_big.jpg as cover_big.jpg, and the value 5eb2a5 as color (i.e. the background colour).

[Olf0]

Developing a new cover image for "Kevin & Kell"
From https://en.wikifur.com/w/images/6/63/KevinandKell.png or http://images.wikia.com/furry/images/6/63/KevinandKell.png	Background set transparent: Worse that route 2, below: Thus not used!
From https://www.kevinandkell.com/images/headerLogo-2024b.png and https://www.kevinandkell.com/images/navbarContainerBackground-2024b.png and	Stitched together: Continued next line …
Logo removed:	Kevin & Kell characters removed:
Logo and characters rearranged on square canvas: Old version 1 with low-quality logo	Background gradient from https://www.kevinandkell.com/images/navbarBackground.png:
Background set to darkest colour of gradient (375d2c):            Old version 1 with low-quality logo	Background set to green gradient (vertically inverted and linearly scaled): Old version 1 with low-quality logo and non-inverted gradient
JPEG ("90% quality") scaled to 300x300 px²: Old version 1 with low-quality logo	JPEG ("90% quality") scaled to 300x300 px²: Old version 1 with low-quality logo and non-inverted gradient
JPEG ("90% quality") scaled to 1000x1000 px²:	JPEG ("90% quality") scaled to 1000x1000 px²:

TL;DR

Although the variant with the inverted gradient looks better IMO, a homogenous background colour is a must, hence please use KevinandKell-cover_bg-green_v2.jpg as cover.jpg, KevinandKell-cover_bg-green_v2_big.jpg as cover_big.jpg, and the value 375d2c as color.

---

P.S.

I also liked this logo from https://api.kingdigital.com/img/features/3892/headers/original.png, but it also has an all white background and one cannot replace the cut-away feet:


 
Thus not useful!

[Olf0]

Oh, I had the impression something was missing and re-read my "Adding a new comic" document:

• Please create a cover_big.jpg file for each comic in this PR from your original graphic material for the corresponding cover.jpg file; just upscaling the 300x300 px² cover.jpg to 1000x1000 px² does not make much sense and creates ugly compression artefacts be re-compression.
  For keeping that "original graphic material" (i.e. not format-converted or scaled, but freed of author names, copyright notices, superfluous graphic elements etc.) for cover and example images, I once created .xdata/plugins, because of issue "[Suggestion] Allow for cover* and example images in (at least) PNG, WEBP and SVG formats #65". Hence please commit such "original graphic material" it there.

  I have already generated such 1000x1000 px² cover_big.jpg images for "Back to B.C." and "Kevin & Kell" above, but have not committed them to your ExTechOp:four_new_comics branch.

  Please also create a separate pull-request branching from the current devel branch as a follow-up to PR "Add four (down from 5) new strips, fix one old one #108" with the cover_big.jpg files for the four comics dealt with there, and extant "original graphic material".

• As you seem to have a local git clone of this repository on a Linux machine, please regenerate the comic covers grid with the resources/generate_covers_grid.sh shell script and regenerate the comics list with the resources/generate_list.sh shell script.
  Preferably in a separate PR after this one and all the cover_big.jpg files have been merged.
  Thanks!