Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tasks for debugging neovim on linux #8

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

fidgetingbits
Copy link
Collaborator

@fidgetingbits fidgetingbits commented Jun 19, 2024

This should close cursorless-dev#2366, as @pokey added OS X tests already. We can't assume what terminal exists on the linux development machine so I added a way to invoke a bunch of the common ones. The caveat here is that you might end up having multiple terminals installed and it could run a terminal that you prefer isn't the default, but I don't think that's a huge deal atm.

There's obviously lots of other terminals that I didn't add but I think this is good enough for now and we can add more in the unlikely event other developers crop up that run into others.

I haven't got as far as being able to actually run the tests yet, but that's due to a bug I need to hunt down that's separate from these tasks. These both at least run and allow me to debug them on attach.

Checklist

@fidgetingbits fidgetingbits requested a review from pokey as a code owner June 19, 2024 07:04
@fidgetingbits
Copy link
Collaborator Author

This now adds other changes I needed to make the tests actually run in my nix dev machine, but with these changes it mostly works. I still run into cursorless-dev#2446 and cursorless-dev#2445 though.

I add the flake.nix for now, with changes that build upon cursorless-dev#1908. Atm cursorless-neovim requires the latest neovim node-client, which isn't in nixpkgs yet. I have an open PR for that, but in the meantime I have to do a manual override from my PR branch, thus the big overlay, which will eventually go away.

I also explicitly call command nvim to avoid any aliases being used, because that caused me massive debug pain at first. I also install a bare version of neovim and prefix PATH so that that version is picked up by vscode first, otherwise also a big pain because of how neovim packaging often works on nix.

@fidgetingbits fidgetingbits mentioned this pull request Jun 24, 2024
@saidelike
Copy link
Owner

Sounds good to me. A few minor feedbacks and rebasing to latest nvim-talon should fix the test on CI failure and we can merge.

@fidgetingbits cursorless-dev#1908 has been merged in main (hence in nvim-talon branch) so I am guessing all the nix stuff can be removed from this PR and it will avoid the merge conflicts too?

@fidgetingbits
Copy link
Collaborator Author

Sounds good to me. A few minor feedbacks and rebasing to latest nvim-talon should fix the test on CI failure and we can merge.

@fidgetingbits cursorless-dev#1908 has been merged in main (hence in nvim-talon branch) so I am guessing all the nix stuff can be removed from this PR and it will avoid the merge conflicts too?

will rebase later today hopefully and see ya. not quite all the Nix stuff can be removed. my PR to update the neovim node plugin in nixpkgs still hasn't landed, so the overlay will still be needed, but the diff will be simpler after rebase for sure.

@fidgetingbits
Copy link
Collaborator Author

Just finished locally testing this after rebase and is all good. Ran into a weird issue related to one of pokey's changes where it couldn't rm -f cursorless-neovim because it was a folder not a symlink, but it was kind of hidden because that folder was also .gitignore'd at some point. Anyway, afaict seems like it's just a remnant of my old test environment and not an actual bug, so should be ok.

Just have to wait for the windows CI test to pass, but it seems like the other ones are passing now so hopefully is good.

@saidelike
Copy link
Owner

Ready to be merged, cc @pokey

@saidelike saidelike assigned pokey and unassigned saidelike Jul 19, 2024
@saidelike saidelike merged commit ebb4e74 into saidelike:nvim-talon Jul 19, 2024
7 checks passed
@fidgetingbits fidgetingbits deleted the neovim-debug branch July 19, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants