-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boxed booleans and getters #199
Comments
Thanks for the PR. This was intentional as boxed Booleans have a third state of NULL, in addition to the true/false. IDEs, tools like Lombok, also generate a getXXX method for boxed booleans. If we need to start supporting isXXX for boxed boolean, it should be fully backward compatible. In other words, we first check for getXXX method, in the event that it is not present, then fall back to isXXX. This ensures we are backward compatible. Let me know your thoughts. |
For me it's important to have 3 states in Boolean. Like yes/no/nodecision. So as @sai-pullabhotla sad, it should be backward compatible and not crash others code logic |
boxed boolean properties where the accessor is of the "isProperty()" format, this can be worked around by adding a ugly "getProperty()" accessor.
I guess IntrospectionUtils::findReadMethodHandle() should include boxed booleans when switching the accessor pattern to look for...
The text was updated successfully, but these errors were encountered: