Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fuzzy find without sorting #22

Merged
merged 1 commit into from
May 30, 2023
Merged

feat: fuzzy find without sorting #22

merged 1 commit into from
May 30, 2023

Conversation

caarlos0
Copy link
Contributor

@caarlos0 caarlos0 commented Aug 12, 2022

alternative FindNoSort method to do only fuzzy matching, without sorting.

This might be useful when the list is already sorted by some other priority and you want to keep that order...

Signed-off-by: Carlos A Becker <[email protected]>
@caarlos0 caarlos0 marked this pull request as ready for review August 12, 2022 23:50
@caarlos0 caarlos0 closed this by deleting the head repository Sep 27, 2022
@caarlos0
Copy link
Contributor Author

caarlos0 commented Nov 16, 2022

@sahilm I think I accidentally closed this somehow.. anyway, are you interested in this?

@caarlos0 caarlos0 reopened this Nov 16, 2022
@mcoops
Copy link

mcoops commented May 30, 2023

Agreed, this would be super handy especially for something like the list in bubbles!

@caarlos0
Copy link
Contributor Author

@mcoops that is precisely why I opened this :P

@sahilm
Copy link
Owner

sahilm commented May 30, 2023

I'm sorry my friends. I have lost interest in life let alone hobby projects. I'm recovering but not there yet.

I can blindly merge. Will this change break existing users?

@sahilm
Copy link
Owner

sahilm commented May 30, 2023

I can't load the diff for some reason. I'm on the mobile app.

@mcoops
Copy link

mcoops commented May 30, 2023

I'm truly sorry to hear that, and I hope things improve for you!

The way @caarlos0 has implemented the change a new function FindNoSort has been added. Only the existing FindFrom now performs the:

sort.Stable(matches) 

So shouldn't be a breaking change.

@sahilm sahilm merged commit c48e322 into sahilm:master May 30, 2023
@sahilm
Copy link
Owner

sahilm commented May 30, 2023

Merged.

@caarlos0
Copy link
Contributor Author

oh, sorry to hear that @sahilm, I hope you feel well soon!

Thanks for the merge! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants