[#404] encoding non-english characters #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheOneTheOnlyDavidBrown could you run |
|
@sahat Done |
sahat
added a commit
that referenced
this pull request
May 13, 2015
…_english_characters [#404] encoding non-english characters
|
Thanks. |
| @@ -295,7 +295,7 @@ | |||
| if (token && token.split('.').length === 3) { | |||
| var base64Url = token.split('.')[1]; | |||
| var base64 = base64Url.replace('-', '+').replace('_', '/'); | |||
| return JSON.parse($window.atob(base64)); | |||
| return JSON.parse(decodeURIComponent(escape(window.atob(base64)))); | |||
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/escape
This feature has been removed from the Web standards. Though some browsers may still support it, it is in the process of being dropped. Do not use it in old or new projects. Pages or Web apps using it may break at any time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #404