Skip to content

Commit

Permalink
no longer calls pollPopup() for mobile inappbrowser
Browse files Browse the repository at this point in the history
  • Loading branch information
sahat committed Jun 8, 2015
1 parent 8f46f3f commit 1152f48
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 12 deletions.
28 changes: 17 additions & 11 deletions satellizer.js
Original file line number Diff line number Diff line change
Expand Up @@ -486,17 +486,22 @@

var url = defaults.authorizationEndpoint + '?' + oauth2.buildQueryString();

return popup.open(url, defaults.name, defaults.popupOptions, defaults.redirectUri)
.pollPopup()
.then(function(oauthData) {
if (defaults.responseType === 'token') {
return oauthData;
}
if (oauthData.state && oauthData.state !== storage.get(stateName)) {
return $q.reject('OAuth 2.0 state parameter mismatch.');
}
return oauth2.exchangeForToken(oauthData, userData);
});
var openPopup;
if (config.platform === 'mobile') {
openPopup = popup.open(url, defaults.name, defaults.popupOptions, defaults.redirectUri)
} else {
openPopup = popup.open(url, defaults.name, defaults.popupOptions, defaults.redirectUri).pollPopup();
}

return openPopup.then(function(oauthData) {
if (defaults.responseType === 'token') {
return oauthData;
}
if (oauthData.state && oauthData.state !== storage.get(stateName)) {
return $q.reject('OAuth 2.0 state parameter mismatch.');
}
return oauth2.exchangeForToken(oauthData, userData);
});

};

Expand Down Expand Up @@ -630,6 +635,7 @@
popup.popupWindow.focus();
}


if (config.platform === 'mobile') {
return popup.eventListener(redirectUri);
}
Expand Down
Loading

0 comments on commit 1152f48

Please sign in to comment.