Skip to content

Commit

Permalink
doc: shorten pull request wait time to 48 hours
Browse files Browse the repository at this point in the history
Currently, we have a 72 rule for how many hours a pull request should
be left open at a minimum. Reduce that time to 48 hours.

PR-URL: nodejs#23082
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Anatoli Papirovski <[email protected]>
  • Loading branch information
Trott authored and sagitsofan committed Oct 12, 2018
1 parent 5932fba commit f414853
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions doc/onboarding.md
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,8 @@ needs to be pointed out separately during the onboarding.
labels.
* Run CI on the PR. Because the PR does not affect any code, use the
`node-test-pull-request-lite-pipeline` CI task.
* After two Collaborator approvals for the change and two Collaborator approvals
for fast-tracking, land the PR.
* After one or two approvals, land the PR (PRs of this type do not need to wait
for 48 hours to land).
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
metadata.
* [`node-core-utils`][] automates the generation of metadata and the landing
Expand Down

0 comments on commit f414853

Please sign in to comment.