Fix building against python-3.10 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polkovnikov: I found your email on your github page just now, should I use that instead (in the commit message)? |
Specifically this build error:
In file included from src/pyuv.c:8:
src/handle.c: In function ‘resurrect_object’:
src/handle.c:17:21: error: lvalue required as left operand of assignment
17 | Py_REFCNT(self) = refcnt;
| ^
Fixes saghul#271.
Co-authored-by: @polkovnikov
bjornfor
force-pushed
the
fix-building-against-python310
branch
from
12b7842
to
e889874
Compare
bjornfor
changed the title
|
python-3.11 has removed/changed more stuff, so I updated the commit message to be correct: this only fixes python-3.10 :-) |
|
It seems CI failures ("AppVeyor build failed") are unrelated -- it aborts due to pip/python being too old or something. I tested this patch in nixpkgs master with python3.7/3.8/3.9/3.10. |
saghul
approved these changes
Jul 4, 2022
|
Thanks! I'm going to try and resurrect the build system in the upcoming weeks. |
|
@saghul: Thanks! |
|
This can be closed now. (I thought my "Fixes ..." comment in the commit message would auto-close, but it didn't.) |
|
Ugh, wrong place! Sorry. |
This was referenced Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically this build error:
Fixes #271.
Co-authored-by: @polkovnikov