Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to #38822: Add missing package update in build/pkgs #38885

Merged
merged 2 commits into from
Nov 16, 2024

Conversation

soehms
Copy link
Member

@soehms soehms commented Oct 29, 2024

This PR just adds the autogenerated package update (produced by sage --package update database_knotinfo 2024.10.1) which was missing in #38822.

@tscrim I'm sorry that I missed that in #38822.

📝 Checklon

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Oct 29, 2024

Documentation preview for this PR (built with commit 242a9a3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@soehms
Copy link
Member Author

soehms commented Oct 30, 2024

Thanks!

@tscrim
Copy link
Collaborator

tscrim commented Nov 13, 2024

Upgrading to blocker since it breaks docbuilding when knotinfo is installed.

@soehms
Copy link
Member Author

soehms commented Nov 13, 2024

For the record:

After solving a merge conflict I tested locally sage -f -c database_knotinfo. This was the positive output:

[database_knotinfo-2024.10.1] [spkg-install] Copying database_knotinfo.egg-info to build/bdist.linux-x86_64/wheel/./database_knotinfo-2024.10.1-py3.12.egg-info
[database_knotinfo-2024.10.1] [spkg-install] running install_scripts
[database_knotinfo-2024.10.1] [spkg-install] creating build/bdist.linux-x86_64/wheel/database_knotinfo-2024.10.1.dist-info/WHEEL
[database_knotinfo-2024.10.1] [spkg-install] creating '/home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/tmp/sage/build/database_knotinfo-2024.10.1/src/dist/.tmp-l7xwzrno/database_knotinfo-2024.10.1-py3-none-any.whl' and adding 'build/bdist.linux-x86_64/wheel' to it
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo/__init__.py'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo/__version__.py'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo/csv_data/knotinfo_data_complete.csv'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo/csv_data/linkinfo_data_complete.csv'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo-2024.10.1.dist-info/LICENSE'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo-2024.10.1.dist-info/METADATA'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo-2024.10.1.dist-info/WHEEL'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo-2024.10.1.dist-info/top_level.txt'
[database_knotinfo-2024.10.1] [spkg-install] adding 'database_knotinfo-2024.10.1.dist-info/RECORD'
[database_knotinfo-2024.10.1] [spkg-install] removing build/bdist.linux-x86_64/wheel
[database_knotinfo-2024.10.1] [spkg-install] Successfully built database_knotinfo-2024.10.1-py3-none-any.whl
[database_knotinfo-2024.10.1] [spkg-install] Staged wheel file, staged /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/lib/sage/scripts/database_knotinfo/spkg-requirements.txt
[database_knotinfo-2024.10.1] Moving package files from temporary location /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/tmp/sage/build/database_knotinfo-2024.10.1/inst to /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5
[database_knotinfo-2024.10.1] [spkg-pipinst] Found existing installation: database-knotinfo 2024.10.1
[database_knotinfo-2024.10.1] [spkg-pipinst] Uninstalling database-knotinfo-2024.10.1:
[database_knotinfo-2024.10.1] [spkg-pipinst]   Successfully uninstalled database-knotinfo-2024.10.1
[database_knotinfo-2024.10.1] [spkg-pipinst] Using pip 24.2 from /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/site-packages/pip (python 3.12)
[database_knotinfo-2024.10.1] [spkg-pipinst] Looking in links: /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/lib/sage/wheels
[database_knotinfo-2024.10.1] [spkg-pipinst] Processing /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/lib/sage/wheels/database_knotinfo-2024.10.1-py3-none-any.whl (from -r /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/var/lib/sage/scripts/database_knotinfo/spkg-requirements.txt (line 1))
[database_knotinfo-2024.10.1] [spkg-pipinst] Installing collected packages: database_knotinfo
[database_knotinfo-2024.10.1] [spkg-pipinst] Successfully installed database_knotinfo-2024.10.1
[database_knotinfo-2024.10.1] Running the test suite for database_knotinfo-2024.10.1...
[database_knotinfo-2024.10.1] [spkg-check] Testing: databases/ features/ knots/
[database_knotinfo-2024.10.1] [spkg-check] /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/bin/sage-venv-config:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
[database_knotinfo-2024.10.1] [spkg-check]   __import__('pkg_resources').require('sagemath-standard==10.5b9')
[database_knotinfo-2024.10.1] [spkg-check] /home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5/bin/sage-runtests:4: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
[database_knotinfo-2024.10.1] [spkg-check]   __import__('pkg_resources').require('sagemath-standard==10.5b9')
[database_knotinfo-2024.10.1] [spkg-check] Running doctests with ID 2024-11-13-09-34-54-1fda828e.
[database_knotinfo-2024.10.1] [spkg-check] Git branch: follow_up_38822
[database_knotinfo-2024.10.1] [spkg-check] Git ref: 10.5.beta9-2-g242a9a3a1f1-dirty
[database_knotinfo-2024.10.1] [spkg-check] Running with SAGE_LOCAL='/home/sebastian/devel/sage/local' and SAGE_VENV='/home/sebastian/devel/sage/local/var/lib/sage/venv-python3.12.5'
[database_knotinfo-2024.10.1] [spkg-check] Using --optional=database_knotinfo,sage
[database_knotinfo-2024.10.1] [spkg-check] Features to be detected: 4ti2,SAGE_SRC,benzene,bliss,buckygen,conway_polynomials,coxeter3,csdp,cvxopt,cvxopt,database_cremona_ellcurve,database_cremona_mini_ellcurve,database_cubic_hecke,database_ellcurves,database_graphs,database_jones_numfield,database_knotinfo,dvipng,ecm,fpylll,fricas,gap_package_atlasrep,gap_package_design,gap_package_grape,gap_package_guava,gap_package_hap,gap_package_polenta,gap_package_polycyclic,gap_package_qpa,gap_package_quagroup,gfan,giac,glucose,graphviz,imagemagick,ipython,jmol,jupymake,jupyter_sphinx,kenzo,kissat,latte_int,lrcalc_python,lrslib,mathics,matroid_database,mcqd,meataxe,mpmath,msolve,nauty,networkx,numpy,palp,pandoc,pdf2svg,pdftocairo,pexpect,phitigra,pillow,plantri,polytopes_db,polytopes_db_4d,pplpy,primecountpy,ptyprocess,pycosat,pycryptosat,pynormaliz,pyparsing,python_igraph,requests,rpy2,rubiks,sage.combinat,sage.geometry.polyhedron,sage.graphs,sage.groups,sage.libs.braiding,sage.libs.ecl,sage.libs.flint,sage.libs.gap,sage.libs.giac,sage.libs.homfly,sage.libs.linbox,sage.libs.m4ri,sage.libs.ntl,sage.libs.pari,sage.libs.singular,sage.misc.cython,sage.modular,sage.modules,sage.numerical.mip,sage.plot,sage.rings.complex_double,sage.rings.finite_rings,sage.rings.function_field,sage.rings.number_field,sage.rings.padics,sage.rings.polynomial.pbori,sage.rings.real_double,sage.rings.real_mpfr,sage.sat,sage.schemes,sage.symbolic,sage_numerical_backends_coin,sagemath_doc_html,scipy,singular,sirocco,sphinx,symengine_py,sympy,tdlib,threejs,topcom
[database_knotinfo-2024.10.1] [spkg-check] Sorting sources by runtime so that slower doctests are run first....
[database_knotinfo-2024.10.1] [spkg-check] Doctesting 75 files using 8 threads.
[database_knotinfo-2024.10.1] [spkg-check] sage -t --long --warn-long 30.0 --random-seed=335768786530535268680430473548074358888 databases/findstat.py
[database_knotinfo-2024.10.1] [spkg-check]     [134 tests, 1.01s wall]
[database_knotinfo-2024.10.1] [spkg-check] sage -t --long --warn-long 30.0 --random-seed=335768786530535268680430473548074358888 databases/sql_db.py
[database_knotinfo-2024.10.1] [spkg-check]     [292 tests, 1.50s wall]
..............
[database_knotinfo-2024.10.1] [spkg-check]     [104 tests, 22.53s wall]
[database_knotinfo-2024.10.1] [spkg-check] sage -t --long --warn-long 30.0 --random-seed=335768786530535268680430473548074358888 knots/free_knotinfo_monoid.py
[database_knotinfo-2024.10.1] [spkg-check] **********************************************************************
[database_knotinfo-2024.10.1] [spkg-check] File "knots/free_knotinfo_monoid.py", line 411, in sage.knots.free_knotinfo_monoid.FreeKnotInfoMonoid.from_knot
[database_knotinfo-2024.10.1] [spkg-check] Warning: slow doctest:
[database_knotinfo-2024.10.1] [spkg-check]     FKIM.from_knot(K)                   # long time
[database_knotinfo-2024.10.1] [spkg-check] Test ran for 30.95s cpu, 30.96s wall
[database_knotinfo-2024.10.1] [spkg-check] Check ran for 0.00s cpu, 0.00s wall
[database_knotinfo-2024.10.1] [spkg-check]     [69 tests, 41.07s wall]
[database_knotinfo-2024.10.1] [spkg-check] sage -t --long --warn-long 30.0 --random-seed=335768786530535268680430473548074358888 knots/knotinfo.py
[database_knotinfo-2024.10.1] [spkg-check] **********************************************************************
[database_knotinfo-2024.10.1] [spkg-check] File "knots/knotinfo.py", line 2308, in sage.knots.knotinfo.KnotInfoBase.is_recoverable
[database_knotinfo-2024.10.1] [spkg-check] Warning: slow doctest:
[database_knotinfo-2024.10.1] [spkg-check]     KnotInfo.K12a_165.is_recoverable(unique=False)  # optional - database_knotinfo, long time
[database_knotinfo-2024.10.1] [spkg-check] Test ran for 36.38s cpu, 36.35s wall
[database_knotinfo-2024.10.1] [spkg-check] Check ran for 0.00s cpu, 0.00s wall
[database_knotinfo-2024.10.1] [spkg-check]     [362 tests, 48.37s wall]
[database_knotinfo-2024.10.1] [spkg-check] ----------------------------------------------------------------------
[database_knotinfo-2024.10.1] [spkg-check] All tests passed!
[database_knotinfo-2024.10.1] [spkg-check] ----------------------------------------------------------------------

Therefore, I set back to positive review.

@vbraun vbraun merged commit 8cf669e into sagemath:develop Nov 16, 2024
32 of 47 checks passed
@soehms soehms deleted the follow_up_38822 branch November 21, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants