Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate install of config.py in meson build #38867

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

antonio-rojas
Copy link
Contributor

The configure_file command creating this config.py file already has install: true which makes it installed by default. Installing it again here creates a duplicate entry in wheel packages, which breaks installing them with some tools (eg. python-installer).

Copy link

Documentation preview for this PR (built with commit 32971da; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vbraun vbraun merged commit 7c62275 into sagemath:develop Nov 3, 2024
18 of 23 checks passed
@antonio-rojas antonio-rojas deleted the meson-config.py branch November 4, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants