Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let the category setup handle the ideals #38821

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

let the category setup handle the ideals #38821

wants to merge 2 commits into from
+88 −193

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Oct 17, 2024 •
edited
Loading

This is removing the ideal methods in the old Ring and Field classes, moving them to the category setup.

Also removing one custom ideal method in multiple polynomial rings.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 9bc8d5a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

note : the removal of "ideal" in multi-polynomial requires a careful check, as it may have hidden side-effects

@fchapoton
Copy link
Contributor Author

At first sight, it seems to be ok thanks to the _ideal_class_ method in src/sage/rings/polynomial/multi_polynomial_ring_base.pyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: categories s: needs review t: refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fchapoton