-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eisenstein series: Small documentation improvement #38484
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 0a58e70; changes) is ready! 🎉 |
What is happening in the |
Ahh oops I didn't see the commit messages. In that case you should write "Depends on #38468" in your PR description. It is a special keyword in GitHub that will make the dependency show up IIRC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One very minor thing, but once fixed, positive review.
Thank you. Positive review. |
Just some small documentation documentation. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. (not aware of one) - [x] I have created tests covering the changes. (no functional change) - [x] I have updated the documentation and checked the documentation preview. -------- Depends on sagemath#38468 to test HTML documentation generation. (But the dependency is not strict, the relevant commits can be cherry-picked out.) URL: sagemath#38484 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
Just some small documentation documentation. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. (not aware of one) - [x] I have created tests covering the changes. (no functional change) - [x] I have updated the documentation and checked the documentation preview. -------- Depends on sagemath#38468 to test HTML documentation generation. (But the dependency is not strict, the relevant commits can be cherry-picked out.) URL: sagemath#38484 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
Just some small documentation documentation. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. (not aware of one) - [x] I have created tests covering the changes. (no functional change) - [x] I have updated the documentation and checked the documentation preview. -------- Depends on sagemath#38468 to test HTML documentation generation. (But the dependency is not strict, the relevant commits can be cherry-picked out.) URL: sagemath#38484 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
Just some small documentation documentation.
📝 Checklist
Depends on #38468 to test HTML documentation generation. (But the dependency is not strict, the relevant commits can be cherry-picked out.)