Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eisenstein series: Small documentation improvement #38484

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Aug 7, 2024

Just some small documentation documentation.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion. (not aware of one)
  • I have created tests covering the changes. (no functional change)
  • I have updated the documentation and checked the documentation preview.

Depends on #38468 to test HTML documentation generation. (But the dependency is not strict, the relevant commits can be cherry-picked out.)

Copy link

github-actions bot commented Aug 7, 2024

Documentation preview for this PR (built with commit 0a58e70; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@grhkm21
Copy link
Contributor

grhkm21 commented Aug 9, 2024

What is happening in the .ci and .github folders?

@user202729
Copy link
Contributor Author

user202729 commented Aug 9, 2024

As explained at the end of the first comment, it's some temporary changes (#38468) to make the online HTML documentation render at all. For merging, if #38468 is not merged before this one, it's best to cherry-pick the relevant commits out only.

@grhkm21
Copy link
Contributor

grhkm21 commented Aug 9, 2024

Ahh oops I didn't see the commit messages. In that case you should write "Depends on #38468" in your PR description. It is a special keyword in GitHub that will make the dependency show up IIRC

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor thing, but once fixed, positive review.

src/sage/lfunctions/dokchitser.py Outdated Show resolved Hide resolved
@tscrim
Copy link
Collaborator

tscrim commented Nov 8, 2024

Thank you. Positive review.

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 9, 2024
    
Just some small documentation documentation.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion. (not aware of one)
- [x] I have created tests covering the changes. (no functional change)
- [x] I have updated the documentation and checked the documentation
preview.


--------



Depends on sagemath#38468  to test HTML
documentation generation. (But the dependency is not strict, the
relevant commits can be cherry-picked out.)
    
URL: sagemath#38484
Reported by: user202729
Reviewer(s): Travis Scrimshaw, user202729
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 13, 2024
    
Just some small documentation documentation.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion. (not aware of one)
- [x] I have created tests covering the changes. (no functional change)
- [x] I have updated the documentation and checked the documentation
preview.


--------



Depends on sagemath#38468  to test HTML
documentation generation. (But the dependency is not strict, the
relevant commits can be cherry-picked out.)
    
URL: sagemath#38484
Reported by: user202729
Reviewer(s): Travis Scrimshaw, user202729
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 14, 2024
    
Just some small documentation documentation.

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion. (not aware of one)
- [x] I have created tests covering the changes. (no functional change)
- [x] I have updated the documentation and checked the documentation
preview.


--------



Depends on sagemath#38468  to test HTML
documentation generation. (But the dependency is not strict, the
relevant commits can be cherry-picked out.)
    
URL: sagemath#38484
Reported by: user202729
Reviewer(s): Travis Scrimshaw, user202729
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants