Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixin' the ruff linter #38309

Merged
merged 4 commits into from
Jul 4, 2024
Merged

fixin' the ruff linter #38309

merged 4 commits into from
Jul 4, 2024

Conversation

fchapoton
Copy link
Contributor

as this is currently badly broken

not sure the changes are all innocuous

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title fixin the ruff' linter (yeah) fixin the ruff' linter Jun 29, 2024
@fchapoton fchapoton changed the title fixin the ruff' linter fixin' the ruff linter Jun 29, 2024
@fchapoton
Copy link
Contributor Author

the fixes in src/sage/manifolds/differentiable/characteristic_cohomology_class.py are breaking the doctests there

@egourgoulhon : please have a look

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 29, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 08f0c91; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mkoeppe
mkoeppe approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@mkoeppe mkoeppe added s: positive review p: CI Fix merged before running CI tests and removed s: needs review labels Jun 29, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jun 29, 2024
@vbraun vbraun merged commit 812a116 into sagemath:develop Jul 4, 2024
21 of 22 checks passed
@fchapoton fchapoton deleted the fix_ruff_linter_checks branch July 5, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
p: blocker / 1 p: CI Fix merged before running CI tests v: small
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun