Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify some calls to join #38165

Merged
merged 3 commits into from
Jun 22, 2024
Merged

simplify some calls to join #38165

merged 3 commits into from
Jun 22, 2024

Conversation

fchapoton
Copy link
Contributor

by avoiding to create the inner list

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Jun 7, 2024

Documentation preview for this PR (built with commit b1f5514; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 10, 2024
    
by avoiding to create the inner list

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38165
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
by avoiding to create the inner list

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38165
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
    
by avoiding to create the inner list

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38165
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 66b3512 into sagemath:develop Jun 22, 2024
17 of 18 checks passed
@fchapoton fchapoton deleted the simplify_joins branch June 22, 2024 19:47
@mkoeppe mkoeppe added this to the sage-10.4 milestone Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants