Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining # coding: utf-8 lines in src/sage #38031

Merged
merged 1 commit into from
May 25, 2024
Merged

Remove remaining # coding: utf-8 lines in src/sage #38031

merged 1 commit into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 19, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this May 19, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 19, 2024 •
edited
Loading

Already reviewed 5 months ago as part of #36964.

@mkoeppe mkoeppe requested a review from kwankyu May 19, 2024 22:54
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 7de2434; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe changed the title Remove remaing # coding: utf-8 lines in src/sage Remove remaining # coding: utf-8 lines in src/sage May 20, 2024
kwankyu
kwankyu approved these changes May 20, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2024

Thanks again!

@vbraun vbraun merged commit 9ac7110 into sagemath:develop May 25, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
t: refactoring v: moderate
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun