Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative to absolute imports, del lazy_import in .all files #38030

Merged
merged 2 commits into from
May 25, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 19, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Matthias Koeppe added 2 commits May 19, 2024 15:13
…print); do sed -i.bak "/from *[.].*import/s/from /from $(echo $d | sed 's,/,.,g')/;s/[.] import / import /;" $d/all*.py; done)
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 19, 2024

Already reviewed 6 months ago in #36676

Copy link

Documentation preview for this PR (built with commit e3bd5b0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@jhpalmieri
Copy link
Member

It looks good. As long as it passes tests, feel free to set a positive review on my behalf. Some all.py files do not have del lazy_import but they can be dealt with later as part of #36721.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2024

Some all.py files do not have del lazy_import but they can be dealt with later

Yes, here I have only picked those del lazy_import additions in files that had other changes already, to keep the PR smaller.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2024

Thanks (again) for the review. Tests pass (see Build&Test using Conda -- Build&Test is fixed in #37926 + #37988).

@jhpalmieri
Copy link
Member

Some all.py files do not have del lazy_import but they can be dealt with later

Yes, here I have only picked those del lazy_import additions in files that had other changes already, to keep the PR smaller.

Right, but I also meant files like combinat/all.py which are changed here. But again, those can wait.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2024

Right, thanks.

@vbraun vbraun merged commit 1858f07 into sagemath:develop May 25, 2024
18 of 19 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants