Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comparison for divisors of curves (and FormalSum commutativity) #37972

Merged
merged 22 commits into from
May 25, 2024
Merged

Fix comparison for divisors of curves (and FormalSum commutativity) #37972

merged 22 commits into from
May 25, 2024

Commits on May 9, 2024

  1. Add some gbuild files to .gitignore

    @vincentmacri
    vincentmacri committed May 9, 2024
    Configuration menu
    Copy the full SHA
    bb5ba20 View commit details
    Browse the repository at this point in the history

  2. Implement __eq__ for curve divisors

    @vincentmacri
    vincentmacri committed May 9, 2024
    Configuration menu
    Copy the full SHA
    a005452 View commit details
    Browse the repository at this point in the history

  3. Undo .gitignore changes

    @vincentmacri
    vincentmacri committed May 9, 2024
    Configuration menu
    Copy the full SHA
    8138a05 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Fix reduce in FormalSum

    @vincentmacri
    vincentmacri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2067172 View commit details
    Browse the repository at this point in the history

  2. Add _coerce_map_from_ in Divisor_generic

    @vincentmacri
    vincentmacri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    3ccedc5 View commit details
    Browse the repository at this point in the history

  3. Fix coercion

    @vincentmacri
    vincentmacri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    0c0f92b View commit details
    Browse the repository at this point in the history

  4. Fix type annotation

    @vincentmacri
    vincentmacri committed May 10, 2024
    Configuration menu
    Copy the full SHA
    2b46497 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Change support to a list, fix tests

    @vincentmacri
    vincentmacri committed May 13, 2024
    Configuration menu
    Copy the full SHA
    aed1ba4 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Travis Scrimshaw <[email protected]>
    @vincentmacri @tscrim
    vincentmacri and tscrim authored May 14, 2024
    Configuration menu
    Copy the full SHA
    d9e2706 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into divisor_curve_eq

    @tscrim
    tscrim authored May 14, 2024
    Configuration menu
    Copy the full SHA
    7ecfccb View commit details
    Browse the repository at this point in the history

  3. Fix for divisor coercion

    @vincentmacri
    vincentmacri committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ff3e442 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Update src/sage/structure/formal_sum.py 

    Co-authored-by: Travis Scrimshaw <[email protected]>
    @vincentmacri @tscrim
    vincentmacri and tscrim authored May 15, 2024
    Configuration menu
    Copy the full SHA
    a547f15 View commit details
    Browse the repository at this point in the history

  2. Fix _coerce_map_from_ in DivisorGroup_generic

    @vincentmacri
    vincentmacri committed May 15, 2024
    Configuration menu
    Copy the full SHA
    3f4f773 View commit details
    Browse the repository at this point in the history

  3. Change formal_sum comparison, revert changes to reduce

    @vincentmacri
    vincentmacri committed May 15, 2024
    Configuration menu
    Copy the full SHA
    725427c View commit details
    Browse the repository at this point in the history

  4. Fix tests

    @vincentmacri
    vincentmacri committed May 15, 2024
    Configuration menu
    Copy the full SHA
    89945bd View commit details
    Browse the repository at this point in the history

  5. Formatting

    @vincentmacri
    vincentmacri committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e8f6a9c View commit details
    Browse the repository at this point in the history

  6. Update src/sage/schemes/generic/divisor.py 

    Co-authored-by: Travis Scrimshaw <[email protected]>
    @vincentmacri @tscrim
    vincentmacri and tscrim authored May 15, 2024
    Configuration menu
    Copy the full SHA
    a6f3e0f View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Travis Scrimshaw <[email protected]>
    @vincentmacri @tscrim
    vincentmacri and tscrim authored May 15, 2024
    Configuration menu
    Copy the full SHA
    6e9b4bb View commit details
    Browse the repository at this point in the history

  8. Coercion change

    @vincentmacri
    vincentmacri committed May 15, 2024
    Configuration menu
    Copy the full SHA
    d572a25 View commit details
    Browse the repository at this point in the history

  9. Update src/sage/schemes/generic/divisor_group.py 

    Co-authored-by: Travis Scrimshaw <[email protected]>
    @vincentmacri @tscrim
    vincentmacri and tscrim authored May 15, 2024
    Configuration menu
    Copy the full SHA
    c5385e1 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Update warning for setting reduce to False in FormalSum

    @vincentmacri
    vincentmacri committed May 16, 2024
    Configuration menu
    Copy the full SHA
    82bbee4 View commit details
    Browse the repository at this point in the history

  2. Clarify wording in reduce False warning

    @vincentmacri
    vincentmacri committed May 16, 2024
    Configuration menu
    Copy the full SHA
    ce4b05c View commit details
    Browse the repository at this point in the history