Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace doctests from jacobian_khuri_makdisi.py taking too long time #37915

Merged
merged 1 commit into from
May 2, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented May 1, 2024

We replace doctest examples in the module sage.rings.function_field.jacobian_khuri_makdisi that are taking too long time with smaller examples.

Before:

sage -t --warn-long 112.9 --random-seed=138126942635581110821969675305757234065 src/sage/rings/function_field/jacobian_khuri_makdisi.py
    [273 tests, 162.67 s]

After:

sage -t --warn-long 113.1 --random-seed=197118826408466343693096609510579001704 src/sage/rings/function_field/jacobian_khuri_makdisi.py
    [272 tests, 122.30 s]

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Remove long doctests from jacobian_khuri_makdisi.py Replace doctests from jacobian_khuri_makdisi.py taking too long time May 1, 2024
Copy link

github-actions bot commented May 1, 2024

Documentation preview for this PR (built with commit 37c3622; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 1, 2024

Thanks!

@vbraun vbraun merged commit e77b3df into sagemath:develop May 2, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants