Implement hypergeometric Euler factors for tame primes #37881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 1de49be; changes) is ready! 🎉 |
tscrim
requested changes
Apr 28, 2024
kedlaya
changed the title
|
I think all the content is (finally) here now, but I'm not sure what's going on with the build failures in CI. |
|
Those build failures are happening across all PRs. I don't know what's going on there either. |
tscrim
requested changes
May 6, 2024
| # now p is good, or p is tame and t is a p-adic unit | ||
| elif (t-1) % p == 0: | ||
| typ = "mult" | ||
| d = (self.degree() - 1) // 2 * 2 |
There was a problem hiding this comment.
I still find it takes me a moment to realize that these operations should not simply cancel (and could follow my suggestion on the first round).
There was a problem hiding this comment.
Maybe it's better to be clear than concise, reworked the logic.
|
For a tentative to repair the currently very broken CI , see #37926 |
tscrim
added
t: enhancement
s: positive review
c: number theory
and removed
v: large
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
We continue the port of hypergeometric motives from Magma by
implementing the computation of hypergeometric traces and Euler factors
for tame primes. This splits into two essentially separate cases: when t
has nonzero p-adic valuation ("tame"), and when t-1 has nonzero p-adic
valuation ("multiplicative"). In the second case, the computation uses
the local functional equation as in the good reduction case.
URL: sagemath#37881
Reported by: kedlaya
Reviewer(s): kedlaya, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
We continue the port of hypergeometric motives from Magma by
implementing the computation of hypergeometric traces and Euler factors
for tame primes. This splits into two essentially separate cases: when t
has nonzero p-adic valuation ("tame"), and when t-1 has nonzero p-adic
valuation ("multiplicative"). In the second case, the computation uses
the local functional equation as in the good reduction case.
URL: sagemath#37881
Reported by: kedlaya
Reviewer(s): kedlaya, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 20, 2024
Since sagemath#37881 was merged, we have the ability to compute hypergeometric traces at the degenerate value t=1. This PR makes a few changes to expose the corresponding functionality for Euler factors (again following the lead of Magma). URL: sagemath#38322 Reported by: kedlaya Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue the port of hypergeometric motives from Magma by implementing the computation of hypergeometric traces and Euler factors for tame primes. This splits into two essentially separate cases: when t has nonzero p-adic valuation ("tame"), and when t-1 has nonzero p-adic valuation ("multiplicative"). In the second case, the computation uses the local functional equation as in the good reduction case.