various ruff fixes in groups (PERF, etc) #37789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0c49d81; changes) is ready! 🎉 |
|
LGTM but there are many other docstring improvements that can be made in |
|
Thanks, but I would prefer to keep my branch as it is. The main focus is about using more list comprehensions. |
gmou3
approved these changes
Apr 11, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 26, 2024
I parsed the `groups` module like a _robot_ and I edited the docstrings. (e.g. 1-line outputs, self to ``self``) ### ⌛ Dependencies Depends on sagemath#37789. URL: sagemath#37790 Reported by: gmou3 Reviewer(s): Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various suggestions of
ruffin thegroupsfolder, mostly aboutPERFcode📝 Checklist