Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize coercion for Hecke algebras #37787

Merged
merged 2 commits into from
May 12, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Apr 11, 2024

Small changes that switch Hecke algebras to the modern coercion framework.

Also avoiding the auld class CommutativeRing and use the categories instead.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

Copy link

github-actions bot commented Apr 11, 2024

Documentation preview for this PR (built with commit 2a56910; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Apr 12, 2024

Are we sure we are not losing the methods:

  • ideal_monoid
  • extension
  • frobenius_endomorphism
  • derivation_module
  • derivation

(as they are all provided by CommutativeRing generically)? Unfortunately I think we have to address this now, and I don't think they are provided. We probably just need to copy them to the CommutativeRings() category.

(localization and fraction_field are for integral domains, so not having them is an improvement (unless Hecke algebras are always an integral domain, but I don't think so?). Actually, are these provided by the category? I don't see them in there. krull_dimension is generically a NotImplementedError.)

@fchapoton
Copy link
Contributor Author

I would prefer to keep this one small, as there is already the big #37719 blocking the view. I am trying to move by little steps only. Here we are getting rid of the last class using CommutativeRing outside of the ring folder.
I understand your concerns, but there is no doctest. Of course, people could use that in the wilderness.

Would it be ok to perform the move of these methods to the category later ? Probably copying them is easier, but there is no doctest ready for testing these copied methods.

@tscrim
Copy link
Collaborator

tscrim commented Apr 12, 2024

I don't think a subclass must include doctests/examples showing the methods defined in a base class work; so I don't find that to be a convincing argument. For ideal_monoid and derivation_module, we can just use the classes at hand here. We could ask one of the number theory people if they have any thoughts (for this specific case) and/or suggestions for such doctests.

I am also happy to do the changes on a separate PR that would become a dependency of this one.

@fchapoton
Copy link
Contributor Author

ok, I will do another PR, but probably not soon

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
    
Small changes that switch Hecke algebras to the modern coercion
framework.

<s>Also avoiding the auld class `CommutativeRing` and use the categories
instead.</s>

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#37787
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
    
Small changes that switch Hecke algebras to the modern coercion
framework.

<s>Also avoiding the auld class `CommutativeRing` and use the categories
instead.</s>

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#37787
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
    
Small changes that switch Hecke algebras to the modern coercion
framework.

<s>Also avoiding the auld class `CommutativeRing` and use the categories
instead.</s>

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
    
URL: sagemath#37787
Reported by: Frédéric Chapoton
Reviewer(s): Travis Scrimshaw
@vbraun vbraun merged commit b590c5a into sagemath:develop May 12, 2024
16 checks passed
@fchapoton fchapoton deleted the modern_coercion_for_hecke branch May 12, 2024 19:57
@mkoeppe mkoeppe added this to the sage-10.4 milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants