-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize coercion for Hecke algebras #37787
Conversation
Documentation preview for this PR (built with commit 2a56910; changes) is ready! 🎉 |
Are we sure we are not losing the methods:
(as they are all provided by ( |
I would prefer to keep this one small, as there is already the big #37719 blocking the view. I am trying to move by little steps only. Here we are getting rid of the last class using Would it be ok to perform the move of these methods to the category later ? Probably copying them is easier, but there is no doctest ready for testing these copied methods. |
I don't think a subclass must include doctests/examples showing the methods defined in a base class work; so I don't find that to be a convincing argument. For I am also happy to do the changes on a separate PR that would become a dependency of this one. |
ok, I will do another PR, but probably not soon |
baacdb2
to
2a56910
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Small changes that switch Hecke algebras to the modern coercion framework. <s>Also avoiding the auld class `CommutativeRing` and use the categories instead.</s> ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#37787 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Small changes that switch Hecke algebras to the modern coercion framework. <s>Also avoiding the auld class `CommutativeRing` and use the categories instead.</s> ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#37787 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Small changes that switch Hecke algebras to the modern coercion framework. <s>Also avoiding the auld class `CommutativeRing` and use the categories instead.</s> ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#37787 Reported by: Frédéric Chapoton Reviewer(s): Travis Scrimshaw
Small changes that switch Hecke algebras to the modern coercion framework.
Also avoiding the auld classCommutativeRing
and use the categories instead.📝 Checklist