Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/sage/modules/with_basis/representation.py: pycodestyle fix #37769

Merged
merged 1 commit into from
Apr 12, 2024
Merged

src/sage/modules/with_basis/representation.py: pycodestyle fix #37769

merged 1 commit into from
Apr 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 9, 2024 •
edited
Loading

Fixes linter failure in 10.4.beta2

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe added s: needs review p: blocker / 1 p: CI Fix merged before running CI tests labels Apr 9, 2024
@mkoeppe mkoeppe self-assigned this Apr 9, 2024
fchapoton
fchapoton approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, thanks

@tscrim
Copy link
Collaborator

tscrim commented Apr 9, 2024

This came from #37393, but I don't know how. The linter was clean there IIRC, and I don't remember having too many blank lines.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Documentation preview for this PR (built with commit 7420741; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 9, 2024

Thanks for the review!

@vbraun vbraun merged commit 7d17cca into sagemath:develop Apr 12, 2024
14 of 17 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@mkoeppe mkoeppe

Labels
p: blocker / 1 p: CI Fix merged before running CI tests
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @tscrim @fchapoton @vbraun