Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for multiprocessing shared memory limits #37702

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

tornaria
Copy link
Contributor

This affects musl libc and macos, see:
#36741 (comment)

We are working on a better fix to avoid using multiprocessing in sage.features (cf #36741 (comment)), but this will do meanwhile.

There is agreement that disabling the lock is completely harmless, since the counter is not really used for anything; disabling the lock fixes the issues that we had on 10.4.beta0.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

This affects musl libc and macos, see:
sagemath#36741 (comment)

We are working on a better fix to avoid using multiprocessing in
sage.features, but this will do meanwhile.

There is agreement that disabling the lock is completely harmless, since
the counter is not really used for anything; disabling the lock fixes
the issues that we had on 10.4.beta0.
Copy link

Documentation preview for this PR (built with commit 7a65d53; changes) is ready! 🎉

Copy link
Member

@soehms soehms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vbraun vbraun merged commit 850ed07 into sagemath:develop Mar 31, 2024
20 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants