Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.doctest: Remove most uses of SAGE_SRC in doctests #37648

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 22, 2024

Using sage.doctest.forker.__file__ whenever Python files are used as inputs for the doctester, instead of going through SAGE_SRC. This makes more of the doctests testable in installations where no source tree is available.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Mar 22, 2024
@mkoeppe mkoeppe changed the title sage.doctest: Use most uses of SAGE_SRC in doctests sage.doctest: Remove most uses of SAGE_SRC in doctests Mar 22, 2024
@mkoeppe mkoeppe requested a review from tornaria March 22, 2024 04:57
Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit 0072e85; changes) is ready! 🎉

@antonio-rojas
Copy link
Contributor

LGTM

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 9, 2024

Thanks for the review!

@vbraun vbraun merged commit 729f337 into sagemath:develop Apr 12, 2024
15 of 16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants