Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Parent in Symbolic Ring #37555

Merged
merged 1 commit into from
Mar 31, 2024
Merged

use Parent in Symbolic Ring #37555

merged 1 commit into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Mar 6, 2024 •
edited
Loading

replacing the auld class CommutativeRing by Parent in the symbolic ring

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2024

Documentation preview for this PR (built with commit 6196143; changes) is ready! 🎉

mkoeppe
mkoeppe approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 8d08115 into sagemath:develop Mar 31, 2024
19 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the symbolic_parent branch April 1, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: symbolics t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun