Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various list-comprehension in combinat (ruff PERF) #37545

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

@fchapoton fchapoton commented Mar 5, 2024

following some ruff --select=PERF src/sage/combinat suggestions

i.e. using more often list comprehension where possible

(also turned one method to an iterator)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link

github-actions bot commented Mar 6, 2024

Documentation preview for this PR (built with commit 32799a6; changes) is ready! 🎉

@mantepse
Copy link
Collaborator

mantepse commented Mar 7, 2024

see #35715 for the doctest error in rings, which is therefore unrelated.

Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vbraun vbraun merged commit a145be7 into sagemath:develop Mar 31, 2024
16 of 18 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the lsit_compr_combinat branch April 1, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants