Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve genus method of function fields and curves #37538

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Mar 4, 2024

  • make genus method of function fields over number fields work.
sage: R.<T> = QQ[]
sage: N.<a> = NumberField(T^2 + 1)
sage: K.<x> = FunctionField(N)
sage: K.genus()
0
sage: S.<t> = PolynomialRing(K)
sage: L.<y> = K.extension(t^2 - x^3 + x)
sage: L.genus()  # not working without this PR
1
  • allow integral curves to be defined over number fields
  • make geometric genus method of integral curves defined over number fields work
sage: R.<x> = QQ[]
sage: N.<a> = NumberField(x^2 + 1)
sage: P2.<x,y,z> = ProjectiveSpace(N, 2)
sage: C = Curve(y^2*z - x^3 + x*z^2, P2)
sage: C.geometric_genus() # not working without this PR
1
  • allow integral curves to be defined from one-dimensional ambient space
sage: R.<x> = QQ[]
sage: N.<a> = NumberField(x^2 + 1)
sage: P1.<x,y> = ProjectiveSpace(N, 1)
sage: C = Curve(P1)
sage: C.geometric_genus()  # not working without this PR
0
  • add comments warning for nonsensical result of geometric genus method applied to geometrically-reducible curves
sage: P2.<x,y,z> = ProjectiveSpace(QQ, 2)
sage: C = Curve(x^2 + y^2, P2)
sage: C.geometric_genus()  # negative geometric genus!
-1
  • remove unnecessary condition (irreducibility) on arithmetic genus of curves
sage: P.<x,y,z> = ProjectiveSpace(QQ, 2)
sage: C = Curve(x^2 - y^2, P)
sage: C.is_irreducible()
False
sage: C.arithmetic_genus()  # not working without this PR
0

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Many fixes related with genus Fixes function fields and curves related with genus Mar 4, 2024
@kwankyu kwankyu changed the title Fixes function fields and curves related with genus Fix function fields and curves related with genus Mar 4, 2024
@kwankyu kwankyu marked this pull request as ready for review March 4, 2024 11:44
@kwankyu kwankyu force-pushed the p/genus branch 2 times, most recently from 614bb3c to 2ccffbf Compare March 5, 2024 05:15
@kwankyu kwankyu changed the title Fix function fields and curves related with genus Improve genus method of function fields and curves Mar 5, 2024
src/sage/rings/function_field/function_field_polymod.py Outdated Show resolved Hide resolved
src/sage/schemes/curves/constructor.py Outdated Show resolved Hide resolved
src/sage/schemes/curves/curve.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 8, 2024

Documentation preview for this PR (built with commit 3b31b1a; changes) is ready! 🎉

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM.

I think these are already nailed in memory in a few places (in one of the categories; if you want to import one from there, please go ahead). I think it would be better to have just one place where such things are constructed if we decide to change this in some fashion. It also can save loading time by a few milliseconds.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 8, 2024

Thanks!

@vbraun vbraun merged commit 455a5cd into sagemath:develop Mar 31, 2024
18 of 19 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants