Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various details in permutation.py (pep8 and ruff PERF) #37469

Merged
merged 1 commit into from
Mar 31, 2024
Merged

various details in permutation.py (pep8 and ruff PERF) #37469

merged 1 commit into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

various small enhancements in permutation.py

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

grhkm21
grhkm21 approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@grhkm21 grhkm21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wondering, do you do these manually?

@fchapoton
Copy link
Contributor Author

yes, I do

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 42ded7c; changes) is ready! 🎉

@vbraun vbraun merged commit 88fd19f into sagemath:develop Mar 31, 2024
24 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the details_in_permutation.py branch April 1, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grhkm21 grhkm21 grhkm21 approved these changes

@mantepse mantepse mantepse left review comments

Assignees
No one assigned
Labels
p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @mantepse @grhkm21 @vbraun @mkoeppe