Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some list comprehensions in rings (ruff PERF401) #37468

Merged
merged 3 commits into from
Mar 31, 2024
Merged

some list comprehensions in rings (ruff PERF401) #37468

merged 3 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

Just changing a few loops to list comprehensions in the rings folder

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title some list comprehensions in rings (ruff PERF) some list comprehensions in rings (ruff PERF401) Feb 25, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 8988fda; changes) is ready! 🎉

mantepse
mantepse approved these changes Feb 27, 2024
View reviewed changes
Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you!

@vbraun vbraun merged commit 00027bd into sagemath:develop Mar 31, 2024
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the list_comp_rings branch April 1, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantepse mantepse mantepse approved these changes

Assignees
No one assigned
Labels
p: minor / 4 t: refactoring
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @mantepse @vbraun @mkoeppe @grhkm21