Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit hypellfrob.pyx #37424

Merged
merged 2 commits into from
Mar 31, 2024
Merged

Edit hypellfrob.pyx #37424

merged 2 commits into from
Mar 31, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Feb 22, 2024 •
edited
Loading

The module hypellfrob.pyx was long neglected and needs to be updated to the current standards. No change in content and code. In particular,

  • shortened the title
  • fixed a broken link
  • moved references to a proper place.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu marked this pull request as ready for review February 22, 2024 10:40
grhkm21
grhkm21 suggested changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@grhkm21 grhkm21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, mostly defining terms more clearly and adding (better) references.

src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
src/sage/schemes/hyperelliptic_curves/hypellfrob.pyx Outdated Show resolved Hide resolved
grhkm21
grhkm21 approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@grhkm21 grhkm21 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes :) Maybe some day I will read the paper in detail haha

@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 22, 2024

Thanks for review!

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit e692602; changes) is ready! 🎉

@vbraun vbraun merged commit 9d2c50f into sagemath:develop Mar 31, 2024
22 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grhkm21 grhkm21 grhkm21 approved these changes

Assignees
No one assigned
Labels
c: documentation p: minor / 4
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@kwankyu @grhkm21 @vbraun @mkoeppe