Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove long/int relic #37420

Merged
merged 5 commits into from
Mar 31, 2024
Merged

Remove long/int relic #37420

merged 5 commits into from
Mar 31, 2024

Commits on Feb 22, 2024

  1. Remove long/int relic 

    in py2, long and int were different types. In py3, only int remains, with long a synonym in cython.
    @nbruin
    nbruin authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    81a71ae View commit details
    Browse the repository at this point in the history

  2. remove int_to_Z because it's buggy 

    int_to_Z used to work in Py2 on the type "int" there which were integers that fit in a word. In Py3 there is no such type anymore and "int" now is what "long" used to be -- -arbitrary length integers. In Py3 int_to_Z is buggy:

sage: itoZ=sage.rings.integer.int_to_Z()
sage: itoZ(1000000000000000000000)
OverflowError
    @nbruin
    nbruin authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    33e14a9 View commit details
    Browse the repository at this point in the history

  3. remove forward declaration of int_to_Z

    @nbruin
    nbruin authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    fa1905c View commit details
    Browse the repository at this point in the history

  4. rename long_to_Z to int_to_Z

    @nbruin
    nbruin authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    d8298b9 View commit details
    Browse the repository at this point in the history

  5. adapt call site to int_to_Z

    @nbruin
    nbruin authored Feb 22, 2024
    Configuration menu
    Copy the full SHA
    18ace4e View commit details
    Browse the repository at this point in the history