Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a polytope method to hypergeometric motives #37404

Merged
merged 4 commits into from
Mar 31, 2024
Merged

add a polytope method to hypergeometric motives #37404

merged 4 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

This is adding one new method to the class of hypergeometric motives, namely the construction of a lattice polytope.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 7, 2024

Documentation preview for this PR (built with commit 6e56381; changes) is ready! 🎉

@fchapoton
Copy link
Contributor Author

good to go ?

mkoeppe
mkoeppe approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchapoton
Copy link
Contributor Author

thanks

@vbraun vbraun merged commit 15f5b63 into sagemath:develop Mar 31, 2024
16 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
@fchapoton fchapoton deleted the polytope_motive branch April 1, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkoeppe mkoeppe mkoeppe approved these changes

Assignees
No one assigned
Labels
c: algebraic geometry
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @mkoeppe @vbraun