Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "Issue #" for github issue links #37403

Merged
merged 6 commits into from
Mar 31, 2024
Merged

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Feb 20, 2024

As discussed in #37390 (comment), we change how Sphinx role :issue: is rendered. For example, short

By Issue #7797, there is a different implementation ...

instead of current

By github issue #7797, there is a different implementation ...

Arguments for the short form are

Please don't do "Github issue". It is a lot of text with extremely little extra value.

In the trac era, it was "trac #7797".

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@kwankyu kwankyu changed the title Use Issue # for github issue links Use "Issue #" for github issue links Feb 20, 2024
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Feb 22, 2024

This has been on sage-devel for enough time for someone to comment if they opposed. I think we can merge this now, and it is a reasonable simplification.

@kwankyu kwankyu marked this pull request as ready for review February 22, 2024 01:50
@kwankyu
Copy link
Collaborator Author

kwankyu commented Feb 22, 2024

Thanks!

@vbraun
Copy link
Member

vbraun commented Mar 20, 2024

merge conflict

@kwankyu
Copy link
Collaborator Author

kwankyu commented Mar 21, 2024

Rebased and fixed.

Copy link

Documentation preview for this PR (built with commit 342f11d; changes) is ready! 🎉

@vbraun vbraun merged commit 653b0d4 into sagemath:develop Mar 31, 2024
15 of 33 checks passed
@mkoeppe mkoeppe added this to the sage-10.4 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants